Changeset 824:1bc79d144eb0 in hatta-dev

Timestamp:

08/30/10 23:42:05 (18 months ago)

Author:

Radomir Dopieralski <hatta-dev@…>

Branch:

default

Message:

Fix some problems and missing imports found using pylint

Location:

hatta

Files:

• page.py (modified) (6 diffs)
• storage.py (modified) (1 diff)
• wiki.py (modified) (9 diffs)

hatta/page.py

@@ -3 +3 @@
 
 import difflib
-import datetime
 import mimetypes
 import re
+import os
 
 import werkzeug
@@ -72 +72 @@
         self.config = self.wiki.config
 
-    def date_html(self, datetime):
+    def date_html(self, date_time):
         """
         Create HTML for a date, according to recommendation at
@@ -78 +78 @@
         """
 
-        text = datetime.strftime('%Y-%m-%d %H:%M')
+        text = date_time.strftime('%Y-%m-%d %H:%M')
         # We are going for YYYY-MM-DDTHH:MM:SSZ
-        title = datetime.strftime('%Y-%m-%dT%H:%M:%SZ')
+        title = date_time.strftime('%Y-%m-%dT%H:%M:%SZ')
         html = werkzeug.html.abbr(text, class_="date", title=title)
         return html
@@ -172 +172 @@
         for link, label in items:
             if link == self.title:
-                class_="current"
+                class_ = "current"
             else:
                 class_ = None
@@ -279 +279 @@
         _ = self.wiki.gettext
         h = werkzeug.html
-        max_rev = -1;
+        max_rev = -1
         title = self.title
         link = self.wiki_link(title)
@@ -370 +370 @@
             comment = _(u'created')
             rev = -1
-        except ForbiddenErr, e:
+        except error.ForbiddenErr, e:
             yield werkzeug.html.p(
                 werkzeug.html(_(unicode(e))))

hatta/storage.py

@@ -2 +2 @@
 # -*- coding: utf-8 -*-
 
-import sys
 import os
 import tempfile

hatta/wiki.py

@@ -5 +5 @@
 import os
 import sys
-import mimetypes
 import re
 import tempfile
+import itertools
 
 import werkzeug
@@ -17 +17 @@
     pygments = None
 
+import hatta
 import storage
 import search
@@ -157 +158 @@
         return werkzeug.url_quote(value.strip(), self.map.charset, safe="/")
 
-    regex='([^+%]|%[^2]|%2[^Bb]).*'
+    regex = '([^+%]|%[^2]|%2[^Bb]).*'
 
 
@@ -163 +164 @@
     """Matches everything."""
 
-    regex='.*'
+    regex = '.*'
 
 
@@ -209 +210 @@
     def __init__(self, config):
         if config.get_bool('show_version', False):
-            sys.stdout.write("Hatta %s\n" % __version__)
+            sys.stdout.write("Hatta %s\n" % hatta.__version__)
             sys.exit()
         self.dead = False
@@ -276 +277 @@
                     try:
                         plus_pos = minor.find('+')
-                        if plus_pos>0:
+                        if plus_pos > 0:
                             minor_base = minor[plus_pos:]
                         else:
@@ -286 +287 @@
                             page_class = self.mime_map[major]
                         except KeyError:
-                                page_class = self.mime_map['']
+                            page_class = self.mime_map['']
         else:
             page_class = page.WikiPage
@@ -480 +481 @@
                 continue
             unique_titles.add(title)
-            if rev>0:
+            if rev > 0:
                 url = request.adapter.build(self.diff, {
                     'title': title,
@@ -902 +903 @@
         def hg_app(env, start):
             env = request.environ
-            prefix='/+hg'
+            prefix = '/+hg'
             if env['PATH_INFO'].startswith(prefix):
                 env["PATH_INFO"] = env["PATH_INFO"][len(prefix):]